Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more core jstests #298

Merged
merged 14 commits into from
Jan 5, 2023
Merged

Add more core jstests #298

merged 14 commits into from
Jan 5, 2023

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Dec 28, 2022

Closes #290.

@b1ron b1ron self-assigned this Dec 28, 2022
@b1ron b1ron added the code/chore Dance tool code maintenance improvements label Dec 28, 2022
@b1ron b1ron closed this Dec 28, 2022
@b1ron b1ron deleted the enable-more-tests branch December 28, 2022 15:23
@b1ron b1ron restored the enable-more-tests branch December 28, 2022 15:34
@b1ron b1ron reopened this Dec 28, 2022
@b1ron b1ron changed the title Add more jstests to the mongo.yml configuration file Add all, array, arrayfind, and find_and_modify to the mongo.yml configuration file Dec 28, 2022
@b1ron b1ron changed the title Add all, array, arrayfind, and find_and_modify to the mongo.yml configuration file Add more core jstests to the mongo.yml configuration file Dec 28, 2022
@b1ron b1ron mentioned this pull request Dec 28, 2022
Closed
@b1ron b1ron changed the title Add more core jstests to the mongo.yml configuration file Add more core jstests Dec 29, 2022
@b1ron b1ron marked this pull request as ready for review December 29, 2022 19:59
@b1ron b1ron requested a review from a team as a code owner December 29, 2022 19:59
@b1ron b1ron enabled auto-merge (squash) December 29, 2022 20:00
@b1ron b1ron disabled auto-merge January 2, 2023 20:43
@b1ron b1ron enabled auto-merge (squash) January 3, 2023 20:43
@b1ron b1ron requested review from a team and w84thesun and removed request for a team January 3, 2023 20:49
rumyantseva
rumyantseva previously approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you found new incompatible things or bugs and created issues for them 👍

That looks good to me overall, I asked one question about TODO without an issue.

tests/mongo.yml Outdated Show resolved Hide resolved
rumyantseva
rumyantseva previously approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chilagrow
chilagrow reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see many tests, just have a comment about auth test 🤗

tests/mongo.yml Show resolved Hide resolved
tests/mongo.yml Show resolved Hide resolved
noisersup
noisersup previously approved these changes Jan 4, 2023
View reviewed changes
@b1ron b1ron dismissed stale reviews from noisersup and rumyantseva via 8850c02 January 4, 2023 11:04
@b1ron b1ron requested a review from chilagrow January 4, 2023 11:04
@b1ron
Copy link
Contributor Author

b1ron commented Jan 4, 2023

@ptrfarkas can you approve this PR please? It needs a code owner's approval.

rumyantseva
rumyantseva approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and the explanation make sense to me.

chilagrow
chilagrow approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like excellent coverage 🤗 thanks for this!

@ptrfarkas ptrfarkas self-requested a review January 5, 2023 11:31
@b1ron b1ron merged commit dfba804 into FerretDB:main Jan 5, 2023
@b1ron b1ron deleted the enable-more-tests branch May 25, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas

Assignees

@b1ron b1ron

Labels
code/chore Dance tool code maintenance improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable more jstests
4 participants
@b1ron @rumyantseva @chilagrow @noisersup