Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate how we can set the TestData object #294

Open
Tracked by #2
b1ron opened this issue Dec 28, 2022 · 2 comments · Fixed by #474
Open
Tracked by #2

Investigate how we can set the TestData object #294

b1ron opened this issue Dec 28, 2022 · 2 comments · Fixed by #474
Labels
code/chore Dance tool code maintenance improvements config Some changes in project configurations

Comments

@b1ron
Copy link
Contributor

b1ron commented Dec 28, 2022 •
edited
Loading

A lot of the jstests rely on a special object called TestData which holds test data. This is set via a .yml file as seen here for the core suite and then passed to the mongo shell. It's also set here.

We should investigate how we can do this in dance as we enable more tests in #290.
@b1ron
Copy link
Contributor Author

b1ron commented Dec 28, 2022

For the core suite it seems trivial however I could be greatly underestimating this task. We could simply pass '--eval TestData = new Object; TestData["skipValidationOnNamespaceNotFound"] = false;' to the shell.

@b1ron b1ron mentioned this issue Jan 4, 2023
Merged
@b1ron b1ron mentioned this issue Mar 27, 2023
Merged
This was referenced Jun 6, 2023
Merged
Merged
@b1ron b1ron added the code/chore Dance tool code maintenance improvements label Jun 6, 2023
@b1ron b1ron moved this to Done in Current Engineering Jun 6, 2023
@b1ron b1ron moved this from Done to In progress in Current Engineering Jun 6, 2023
@b1ron b1ron assigned b1ron and unassigned ferretdb-bot Jun 6, 2023
@b1ron b1ron closed this as completed in #474 Jun 9, 2023
b1ron added a commit that referenced this issue Jun 9, 2023
@b1ron
Set TestData object to allow more tests to run (#474)
3fb1a6a 
Closes #294.
@b1ron
Copy link
Contributor Author

b1ron commented Jun 9, 2023

We still do not fully understand what needs to be set under what conditions so reopening to keep track of issue.

@b1ron b1ron reopened this Jun 9, 2023
@b1ron b1ron moved this from In progress to Open in Current Engineering Jun 9, 2023
@AlekSi AlekSi mentioned this issue Aug 17, 2023
Closed
@AlekSi AlekSi added the config Some changes in project configurations label Aug 19, 2024
@AlekSi AlekSi mentioned this issue Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code/chore Dance tool code maintenance improvements config Some changes in project configurations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set TestData object to allow more tests to run
3 participants
@AlekSi @b1ron @ferretdb-bot