Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Commit

Permalink
off-by-v error in spelling of versions
Browse files Browse the repository at this point in the history
  • Loading branch information
seebs committed Mar 30, 2023
1 parent 9460bc9 commit a5dda0c
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions idk/ingest_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,10 @@ func TestFeaturebaseVersion(t *testing.T) {
if expectedTag != "" {
// if a tag is set, we're in a tagged pipeline, and the version
// should just be vX.Y or something similar, without a commit
// hash.
if v != expectedTag {
// hash. in that case, the tag passed to us from the environment
// will look like vX.Y, but the version reported by the version
// endpoint is just X.Y. Argh.
if v != expectedTag && ("v"+v) != expectedTag {
t.Fatalf("version %s does not match expected tag %s", v, expectedTag)
}
t.Logf("featurebase version %q matches expectations", expectedTag)
Expand Down

0 comments on commit a5dda0c

Please sign in to comment.