Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes for all values listed in https://yaml.org/type/bool.html #137

Conversation

GuillaumeSmaha
Copy link
Contributor

Fix #129

GuillaumeSmaha added a commit to GuillaumeSmaha/openapi-generator that referenced this pull request Jun 28, 2019
 quotes around string value and fix compatibility with parser using yaml 1.1.

Fix OpenAPITools#3196

In spec 1.1, some words without quotes can be implicitly converted to
 a boolean like "yes" or "on" (See https://yaml.org/type/bool.html)
In v3.core.util.Yaml with MINIMIZE_QUOTES enabled, the formatter created
 a YAML but forget to protect some words.

PRs are created to fix this in the formatter:
 - FasterXML/jackson-dataformats-text#137
 - FasterXML/jackson-dataformats-text#138

Until the PRs will be merged and released, this patch fix it by
re-adding quotes.
@cowtowncoder
Copy link
Member

Quick question: have I already asked for a CLA? If not (this is your first contribution), I would need it (but just once, not for further contributions). Document is here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print, fill & sign, scan, email to info at fasterxml dot com.
Once I get that, I'll merge this PR.

Thank you in advance!

@GuillaumeSmaha
Copy link
Contributor Author

@cowtowncoder I filled the CLA and sent it by email.

@cowtowncoder cowtowncoder merged commit 507d6e6 into FasterXML:2.10 Jul 18, 2019
@cowtowncoder cowtowncoder added this to the 2.10.0 milestone Jul 18, 2019
@cowtowncoder cowtowncoder added the yaml Issue related to YAML format backend label Jul 18, 2019
@GuillaumeSmaha GuillaumeSmaha deleted the protect_value_to_avoid_implict_convertion branch July 18, 2019 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
yaml Issue related to YAML format backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants