Allow escaping of non-printable characters in CSV output/input #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed solution for FasterXML#124. It introduces a new Feature, `ESCAPE_CONTROL_CHARS_WITH_ESCAPE_CHAR`, which will apply the standard ASCII escapes from JSON to all characters that the CSV generator writes. If this solution is workable, I will add tests.
|
The same patch also applies cleanly to the 2.10 code branch. |
|
@cowtowncoder ping? Any chance for you to weigh in / reject here? |
|
Ok, merged, will be in 2.9.9. Forgot to ask for a unit test to verify, but that can be added at a later point. |
cowtowncoder
added a commit
that referenced
this pull request
May 4, 2019
pjankovsky
pushed a commit
to fivetran/jackson-dataformats-text
that referenced
this pull request
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for #124. It introduces a new Feature,
ESCAPE_CONTROL_CHARS_WITH_ESCAPE_CHAR,which will apply the standard ASCII escapes from JSON to all characters that the CSV generator writes.
If this solution is workable, I will add tests.