-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for sorted trees #3995
Support for sorted trees #3995
Conversation
…s children map. This allows to create sorted trees.
Since you implemented sorting in a different way, I'll close this one. |
Ok; I was considering accepting this too, but hadn't formed an opinion yet -- it is a valid approach too (and bit more powerful). But just for canonical JSON probably not worth pursuing at this point. |
Okay, I thought this one was breaking too much. Reopened. Take your time. |
Turns out the problem with |
why is JsonNodeFactory serializable? |
It is referenced by ObjectMapper (part of configurarion not transient
state) which needs to be serializable
…On Mon, Jun 26, 2023 at 9:23 AM Jonas Konrad ***@***.***> wrote:
why is JsonNodeFactory serializable?
—
Reply to this email directly, view it on GitHub
<#3995 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANOGI3E6AUVTEWHMQCDNTXNETHZANCNFSM6AAAAAAZLBPT3A>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Looks like the trick doesn't work on Android. Options left:
Which way do you want to go? |
why does this not work on android? |
Looks like there is a failure for "animal-sniffer" plugin, which is used to guard against unintended changes to levels of Android SDK that |
Ok, I don't think I want to proceed with this PR; closing. There is #3965 that adds |
This patch moves the factory for
ObjectNode
's children to theJsonNodeFactory
.Along with a new
deepCopy()
method inJsonNodeFactory
, this allows to create sorted trees from the mapper or sort existing trees by copying them with aJsonNodeFactory
where sorting is enabled.There was a problem with
TestJDKSerialization
but that could be fixed very easily with just adding an interface which mergesSerializable
andSupplier<T>
; Java then knows what to do.