-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cfg for hex values if we want upper or lowercase letters #819
add cfg for hex values if we want upper or lowercase letters #819
Conversation
src/main/java/com/fasterxml/jackson/core/JsonStreamContext.java
Outdated
Show resolved
Hide resolved
Looks mostly good, thank you for contributing this! As to testing, I think it should go somewhere under Aside from that, one thing I will need before merging (and about only thing) is CLA. https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf (or Corporate CCLA next to it). the usual way is to print, fill & sign, scan, email to Looking forward to merging this! |
Thx for fast feedback, ill print the CLA out tomorrow and send it to you. |
src/test/java/com/fasterxml/jackson/core/write/UTF8GeneratorTest.java
Outdated
Show resolved
Hide resolved
Okay, Mail should be in your inbox. |
CLA received, can merge. |
For issue #717 I tried to make this configurable.
Its my first PR here, I didnt found a good spot for testing, would be nice if you can point me out where to do this.