Add fields to reaction statistics to track CPU time #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be in another PR)
TrentHouliston
changed the title
TrentHouliston
added a commit
that referenced
this pull request
Aug 15, 2024
…events (#125) Changes ReactionStatistics so it no longer only fires at the very end of a reaction. It will now fire progress updates as it goes through to allow monitoring of how reactions are going. It also better conforms to trace file semantics so that they can be used to track reactions Superceeds #99 as it integrates those changes too
|
Superceeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to real-time values, reaction statistics is in the position where it can also measure the actual CPU time that the reaction has taken up.
In a very congested environment (e.g. lots of threads on few cores) it's possible for the real-time that a reaction takes to not be reflective of its actual performance if there were more resources available.
For example, imagine one CPU core is processing two tasks which take 1 second each. Depending on how the CPU time gets divided, you could end up with both tasks taking 2 seconds in real time while each only actually had 1 second of total CPU time.
This adds two new values to reaction statistics, one for user CPU time and one for system CPU time.