Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test timeouts to be in realtime #129

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

TrentHouliston
Copy link
Member

@TrentHouliston TrentHouliston commented Aug 18, 2024

The current tests use on for timing out tests.
This doesn't work if you manipulate the clock as the watchdog may never fire.

This changes it to just waiting for a specific amount of real time before ending the test.

Also makes the following other changes

  • Makes the amount of time to wait a constuctor arugment rather than a template argument
  • Makes a Fail struct that can be emitted to fail the test with a message (used by timeout)
  • Adds a force option to powerplant shutdown to make it remove all queued tasks

@TrentHouliston TrentHouliston changed the title Make tests pass in their timeout, and don't use watchdog as for tests like TimeTravel where we manipulate the clock it won't work. Change test timeouts to be in realtime Aug 18, 2024
@TrentHouliston TrentHouliston merged commit 7b3305d into main Aug 20, 2024
3 of 13 checks passed
@TrentHouliston TrentHouliston deleted the houliston/dynamic_timeout branch August 20, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant