Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge fmt #24

Merged
merged 2 commits into from
Jan 8, 2024
Merged

forge fmt #24

merged 2 commits into from
Jan 8, 2024

Conversation

ephess
Copy link
Contributor

@ephess ephess commented Jan 8, 2024

No description provided.

Copy link
Contributor

@jj1980a jj1980a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! a small detail I keep noticing, comments explaining the next if/else case but placed in the previous block, like:

// this comment explains the following if
if (a == 1) {
    ...
    // this comment explains the next else if
} else if (a == 2) {
    ...
    // this comment explains the next else
} else {
    ...
}

there's only a few occurrences, but can we place comment in the block scope they belong to?

Copy link
Contributor

@BenSparksCode BenSparksCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with @jj1980a's note on comments being inside the blocks they describe - a style change we recently discussed for Atlas as well

Base automatically changed from remove-legacy-auction to main January 8, 2024 22:34
@ephess
Copy link
Contributor Author

ephess commented Jan 8, 2024

Fixed

@ephess ephess merged commit 8af657f into main Jan 8, 2024
1 check passed
@ephess ephess deleted the forge-fmt branch January 8, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants