Msg value refund #20
Merged
Msg value refund #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…centive for searchers to overpay as little as possible thereby increasing odds of failure
jj1980a
approved these changes
Jan 4, 2024
BenSparksCode
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
LGTM
Only note is that I just added evm_version = 'paris' in the Foundry settings as the Solidity compiler version is now set to 0.8.20 which would include PUSH0 by default, which is not currently supported on Polygon PoS. Targeting Paris EVM version should make this safe for Polygon.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refund the msg.value to sender when the searcher call throws, to prevent it accumulating on the contract.