fix: no more empty groups in generated svgs #1235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DOM tree was parsed to remove empty groups, the indexation of the QDomNodeList was being changed each time a node was deleted, to reflect the new state of the DOM tree. The code wasn't taking this into consideration and empty nodes were missed.
Now I'm removing the empty groups 1 by 1, starting the search over each time a node is deleted, to take into consideration the new indexation of the QDomNodeList.
There may be some more efficient ways of cleaning the empty groups, but this one is probably the easiest.