Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notch width and seam line display in pattern pieces #1232

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Dec 15, 2024

This PR fixs the notch width and seam line display.

  • Notch width is now set to the cut line width.

image

  • Seam line now displays correctly.

image

  • Adds a 3.00 mm lineweight

image

  • Bumps schema to pattern ver 0.7.2

Closes issue #1231

Copy link

what-the-diff bot commented Dec 15, 2024

PR Summary 📚

Keep up the great work, team! We've got some exciting updates that will make our software even better! Let's dive in!🌊

  • Introducing New Line Weight 🖌️
    Brought in a fresh "3.00mm" line weight (the thickness of our lines) to soup up our drawing kit. It's been set up in the backbone of the program so it fits in seamlessly.

  • Updated Schema File 🗃️
    Added a new framework file (v0.7.2.xsd). This frame assists us in keeping the data well-organized and accurate.

  • Upgraded Maximum Version String 🆙
    Upgraded the software's version string to "0.7.2". This neat changes help the application stay current and in line with our latest improvements.

  • Better Management of Paint Color and Line Weights 🎨
    Tweaked how we handle both paint color and line weights. We've optimized things so our default cut line weight setting is used more effectively.

  • Enhanced Pattern Piece Tool 🔧
    Our Pattern Piece Tool got a major lift! It's now better at managing brush settings for drawing notches and allowances, so you can draw more fluidly.

  • More Visible Items in ComboBox 👀
    Enhanced our visual selection tool to show up to 25 items at once, ensuring our new line weight is included and easily accessible.

Great job on these changes everyone. We're continually growing and empowering our software, and it's all because of you! 🎉

@DSCaskey DSCaskey changed the title fix notch and path line weights in pattern pieces fix: notch width and seam line display in pattern pieces Dec 15, 2024
@DSCaskey DSCaskey linked an issue Dec 15, 2024 that may be closed by this pull request
@slspencer slspencer requested a review from Onetchou December 17, 2024 18:42
@slspencer
Copy link
Collaborator

@Onechou

Copy link
Contributor

@Onetchou Onetchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 😊

@Onetchou Onetchou merged commit b08abd8 into develop Dec 30, 2024
10 checks passed
@Onetchou Onetchou deleted the fix-notch-lineweight branch December 30, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Notch width is set by the seam line instead of cut line
3 participants