Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix position option in edit fx dialog #1208

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

DSCaskey
Copy link
Contributor

This PR fixes the dialog position option in the Edit Formula dialog.

Closes issue #1203

Copy link

what-the-diff bot commented Nov 11, 2024

PR Summary 🚀

This detailed work delivers awesome improvements to our project's coding standards and usability. Here's a friendly summary of what's been done:

🖊️ Coding Standards and Readability

  • Updated and Enhanced Comments : We now have a consistently formatted set of comments in edit_formula_dialog.cpp and edit_formula_dialog.h. Big kudos to those who enjoy reading through the code - it's going to be a lot more straightforward now! 🤓

  • Switched to Single-line Comments : We have less clutter now and clearer code - we've done away with our old multi-line comment blocks and replaced them with sleek, single-line comments.

  • Split-up Function Descriptions : Awesome work, team! We now have neat segments in our files that highlight what each function is meant to do. This way, it's more intuitive to grasp the purpose of each function at a glance. 🚀

🛠️ Code Consistency and Positioning

  • Harmonized Function Declarations : Further tidying up, we now have a unified layout for function declarations in the header file.

  • Enhanced Dialog Positioning : User satisfaction is on the up! There's been an update to the showEvent function in edit_formula_dialog.cpp to ensure the dialog box's position matches what the user prefers.

🏢 Updates and Tweaks

  • Copyright Year Update : We're keeping our files current, the copyright year in editlabeltemplate_dialog.cpp and editlabeltemplate_dialog.h has been updated to 2023.

  • Comment Style Shift : Lastly, we have neatened up the style of our comments in the same two files. The bulk comment blocks are out and dashed-line comments are in, boosting readability.

Let's keep up this fantastic work, team! 🎉

@DSCaskey DSCaskey changed the title bug: fix position option to edit fx dialog bug: fix position option in edit fx dialog Nov 11, 2024
@csett86 csett86 merged commit b30abb6 into develop Nov 17, 2024
10 checks passed
@csett86 csett86 deleted the add-setposition-to-some-missing-dialogs branch November 17, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants