-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added radius rescaling to simple env #1213
Added radius rescaling to simple env #1213
Conversation
Hi @elliottower, just wanted to bring your attention to this PR. Let me know if it requires any changes, would be glad to add them! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for necro-ing this PR. the maintainers of PZ went on a short hiatus and are now getting back to things.
Thanks for the fix! Looks good to go for me, once precommit is fixed then we can merge. :) |
Gotcha, for the precommit I just need to modify the formatting of my files right? The tutorial failures seem unrelated to this PR. |
@jjshoots I have modified the formatting and the pre-commit check passes now. Thanks for reviewing my PR! PS: I just glanced over your website, your journey across the 'remote Pacific' is sooo cool. Is there a place where I can message you to learn more about it? 😄 |
LGTM! Thanks for the addition. You can contact me on Discord @jjshoots |
Description
This PR implements dynamic rescaling of the entity radius as we 'Zoom In' or 'Zoom out' of the rendering. This fixes #1188 which mentions that keeping the radius constant when rescaling the coordinates leads to an illusion of fixed obstacles coming closer or moving away from each other when in reality they are fixed.
Files modified: simple_env.py
High-level overview: Extended the concept of cam_range and recorded the original cam_range to scale the radius
Fixes #1188 , Depends on None
Type of change
Screenshots
Notice how the zoom out effect is more intuitive in the dynamic resizing case
Before dynamic resizing:
After dynamic resizing:
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no new errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.