Correct obs type in parallel_rps doc example #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value was an int, but all the testing expects obsevations to be numpy types. This has been changed with updates comments to explain.
elliottower
reviewed
Jan 25, 2024
docs/code_examples/parallel_rps.py
Outdated
| observations = { | ||
| self.agents[i]: int(actions[self.agents[1 - i]]) | ||
| self.agents[i]: np.array(actions[self.agents[1 - i]], dtype=np.int_) |
There was a problem hiding this comment.
Is np.int_ the correct dtype?
There was a problem hiding this comment.
Actually, it looks like np.int64 may be the most correct choice. int_ is the same on most platforms, but maybe not all
There was a problem hiding this comment.
Yeah int64 is what I've seen elsewhere in the code
There was a problem hiding this comment.
If you could fix this I can merge it
There was a problem hiding this comment.
I pushed a fix the pr
elliottower
reviewed
Jan 25, 2024
7 tasks
correct type and update name to be less confusing
|
I updated the type to int64, and made the initial state a bit more clear |
elliottower
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value was an int, but all the testing expects observations to be numpy types. This has been changed with updated comments to explain.
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)pytest -vand no errors are present.pytest -vhas generated that are related to my code to the best of my knowledge.