Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo simple_reference docstring, fix workflows to use python 3.11 by default #1128

Merged

Conversation

elliottower
Copy link
Contributor

Description

Fixes issues in #1123, see comments there for context about MPE docstring update

Workflows were updated to use v4 of checkout and setup-python just for the sake of future proofing, there were some warnings about old node versions and stuff like that. I also fixed the python version for things like doc build to use python 3.11 instead of 3.9. Pre-commit was doing python 3.12 because the version was unspecified, so that has been fixed as well (tested locally and 3.12 seems to just have issues with flake8, we can wait for 312 support as it was just released last month)

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower
Copy link
Contributor Author

I also noticed there were some weird extra spaces in some of the YML files, I think it was a mistake from a previous pre-commit thing I had to reformat YML, fixed it to look normal now

@elliottower
Copy link
Contributor Author

Looks like an agilerl issue but everything else passes, may wait for that PR to merge this

@elliottower elliottower merged commit defe0d1 into Farama-Foundation:master Nov 7, 2023
43 checks passed
@elliottower elliottower deleted the docs-typo-gh-actions-update branch November 7, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants