Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat Boots #335

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Combat Boots #335

merged 7 commits into from
Nov 8, 2024

Conversation

VividPups
Copy link
Contributor

Adds new combat boots to Sec

Description

how many times have you as a secoff couldn't do your job because of space wind? way too fuckin much if you ask me. So therefor I made these boots. These boots are not only an item Oracle will request but also a Research item under riot control (space riots are real) Now according to SOP mag boots are a restrictive item for engis meaning that Sec shouldn't be going out of their a way to find them and try and get them (Bad sec off) but, now this with this item Warden and HOS (After research) can regulate who can have them and when it can be handed out..
(Cost of making them can change really just didn't know what to put should probably be more steel that's for sure)

Also, this could help when later down the road we might finally be able to get nukies

Media

image

Changelog

🆑

  • add: New Combat Boots!

Adds new combat boots to Sec
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files labels Nov 6, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Combat boots Combat Boots Nov 6, 2024
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While good is good, Personnaly giving Security Magboots that does not slow down is a no-no for me.

MAGBOOTS SLOWS EVERYONE DOWN EXCEPT THE ADVANCED/EXPERIMENTAL ONES witch should be UNIQUE.

But regarding SOP that apprently "not everyone can use magboots" for me that bullshit too, magboots should be buildable in science at peoples request, ect...

I will put this under maintainer review.

@FoxxoTrystan FoxxoTrystan added Priority: 3-Low Should be resolved at some point Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. labels Nov 6, 2024
@VividPups
Copy link
Contributor Author

While good is good, Personnaly giving Security Magboots that does not slow down is a no-no for me.

MAGBOOTS SLOWS EVERYONE DOWN EXCEPT THE ADVANCED/EXPERIMENTAL ONES witch should be UNIQUE.

But regarding SOP that apprently "not everyone can use magboots" for me that bullshit too, magboots should be buildable in science at peoples request, ect...

I will put this under maintainer review.

The reason why I put it as no slow

While good is good, Personnaly giving Security Magboots that does not slow down is a no-no for me.

MAGBOOTS SLOWS EVERYONE DOWN EXCEPT THE ADVANCED/EXPERIMENTAL ONES witch should be UNIQUE.

But regarding SOP that apprently "not everyone can use magboots" for me that bullshit too, magboots should be buildable in science at peoples request, ect...

I will put this under maintainer review.

The reason why I put it at no slow down is because amount of mobs that way to fast to have it like the regular the only real threats are the dragon, ninja and ratking all which have significantly faster and can kill their enemy. Also, I have not once have seen Advance or experimental magboots. (Unless you are talking about the single boots that CE has)

@FoxxoTrystan
Copy link
Collaborator

While good is good, Personnaly giving Security Magboots that does not slow down is a no-no for me.
MAGBOOTS SLOWS EVERYONE DOWN EXCEPT THE ADVANCED/EXPERIMENTAL ONES witch should be UNIQUE.
But regarding SOP that apprently "not everyone can use magboots" for me that bullshit too, magboots should be buildable in science at peoples request, ect...
I will put this under maintainer review.

The reason why I put it as no slow

While good is good, Personnaly giving Security Magboots that does not slow down is a no-no for me.
MAGBOOTS SLOWS EVERYONE DOWN EXCEPT THE ADVANCED/EXPERIMENTAL ONES witch should be UNIQUE.
But regarding SOP that apprently "not everyone can use magboots" for me that bullshit too, magboots should be buildable in science at peoples request, ect...
I will put this under maintainer review.

The reason why I put it at no slow down is because amount of mobs that way to fast to have it like the regular the only real threats are the dragon, ninja and ratking all which have significantly faster and can kill their enemy. Also, I have not once have seen Advance or experimental magboots. (Unless you are talking about the single boots that CE has)

Yes CE boots are normally unique, we are reviewing this and still go back to you.

@FoxxoTrystan FoxxoTrystan self-requested a review November 6, 2024 13:37
@Memeji Memeji self-requested a review November 6, 2024 13:43
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a tiny talk here what i suggest, first advanced magboots is a nono but giving modified magboots for combat is fine to the security lathe, just make sure cost is not below normal magboots and make the research instead under "MagnetsTech", you will need to move ClothingShoesBootsMagCom under there.

Also i suggest that you could give them a custom/different sprite: here one from Frontier that could work: https://github.com/new-frontiers-14/frontier-station-14/tree/master/Resources/Textures/_NF/Clothing/Shoes/Boots/magboots-combat.rsi

Suggestion to assit you are below, if need assistance do tell.

Resources/Prototypes/Research/arsenal.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Floof/Recipes/Lathes/security.yml Outdated Show resolved Hide resolved
@FoxxoTrystan FoxxoTrystan added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review Someone please review this Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. labels Nov 6, 2024
@VividPups
Copy link
Contributor Author

After a tiny talk here what i suggest, first advanced magboots is a nono but giving modified magboots for combat is fine to the security lathe, just make sure cost is not below normal magboots and make the research instead under "MagnetsTech", you will need to move ClothingShoesBootsMagCom under there.

Also i suggest that you could give them a custom/different sprite: here one from Frontier that could work: https://github.com/new-frontiers-14/frontier-station-14/tree/master/Resources/Textures/_NF/Clothing/Shoes/Boots/magboots-combat.rsi

Suggestion to assit you are below, if need assistance do tell.

the problem is again what is going to happen is that current antags are going to be much faster than the Secoff trying to defend the station which will just cost more deaths

updates
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current antags has the same problem as security regarding gravity, Magboots are toggable.
wana walk normal speed? toggle it off.

No Gravity? Toggle it on.

@VividPups
Copy link
Contributor Author

Current antags has the same problem as security regarding gravity, Magboots are toggable. wana walk normal speed? toggle it off.

No Gravity? Toggle it on.

and then you trip and die, or you toggle the antag gets in your range and kills you that's the problem. it happen last night with a loneop

@FoxxoTrystan
Copy link
Collaborator

Current antags has the same problem as security regarding gravity, Magboots are toggable. wana walk normal speed? toggle it off.
No Gravity? Toggle it on.

and then you trip and die, or you toggle the antag gets in your range and kills you that's the problem. it happen last night with a loneop

Then be carefull, even loneop/Syndicate magboots are not advanced.

Updated
@github-actions github-actions bot added Status: Needs Review Someone please review this and removed Status: Awaiting Changes Do not merge due to requested changes labels Nov 7, 2024
@VividPups
Copy link
Contributor Author

all Request has been made

Copy link
Owner

@Fansana Fansana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shoes will need their own sprite. Working on it, do not merge.

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an RSI label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

RSI Diff Bot; head commit 7a3d414 merging into b299cdb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi

State Old New Status
equipped-FEET-vox Added
equipped-FEET Added
icon-on Added
icon Added
inhand-left Added
inhand-right Added
on-equipped-FEET-vox Added
on-equipped-FEET Added
on-inhand-left Added
on-inhand-right Added

@Fansana Fansana merged commit 982c78f into Fansana:master Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Low Should be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants