feat: support STRM files in library as available content #1004
+15
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o would fail current check for 'other resolution'
Support strm files, which won't have mediastream data until played, s…
alanmilinovic
requested review from
Fallenbagel and
gauthier-th
as code owners
1 task
|
Can someone please review? |
Please be patient. We are working on reviewing prs. Currently we have app breaking bugs in 2.0.0 that we need to put higher priority on |
Fallenbagel
changed the title
gauthier-th
requested changes
Oct 28, 2024
alanmilinovic
commented
Oct 28, 2024
gauthier-th
requested changes
Oct 28, 2024
gauthier-th
requested changes
Oct 28, 2024
| @@ -96,7 +96,7 @@ class JellyfinScanner { | |||
| (MediaStream) => MediaStream.Type === 'Video' | |||
| ).some((MediaStream) => { | |||
| return (MediaStream.Width ?? 0) <= 2000; | |||
| }); | |||
| }) || MediaSource.Container === 'strm'; | |||
There was a problem hiding this comment.
By doing this, all STRM media will be considered non-4k media. Right now I don't know what method to use, but you have to find a way to retrieve the media definition.
There was a problem hiding this comment.
hm, I also have no idea.
|
You have to find a way to retrieve the media definition of the STRM stream to be classified as non-4k or 4k. You can't classify every STRM as non-4k. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presence of a STRM container file for an item in Emby / Jellyfin should result in the item being marked as available
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed