Add conventional tag for all animals #4168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've already made a PR to NeoForge neoforged/NeoForge#1596, and if wanted, I can make a PR to the 1.21.2 branch as well |
|
Seems fine to me |
TelepathicGrunt
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on a mod, and found a sudden need for a tag that included all animals, ideally one that other mods would include their animals in. It doesn't exist in the base game, and this is the next best thing.
As for why I can't just use an
instanceofcheck, it's because I also need to cover players, illagers, villagers, and wandering traders while still allowing the list of acceptable entities to be configurable by the end user. I'm using a tag of my own, and then including players, villagers, and wandering traders explicitly, then using the existingminecraft:illagerstag for all the illagers, and would like to use ac:animalstag for animals.