Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Property for recursive mod loading #994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

notTamion
Copy link

fixes #81
This pr adds the -Dfabric.loadModsRecursively system property which will cause the default mods folder to be loaded recursively. Paths containing "disabled" are ignored. This way we don't break existing setups which use a subfolder with any name to make sure mods are not loaded but provide users with an option to easily categorize their mods

Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can already be done with -Dfabric.addMods=mods

See: #470

@notTamion
Copy link
Author

Yes, however the addMods property does not allow you to easily disable entire folders without having to rename all the files or moving them outside the mod folder completetly, also having the mods folder scanned twice feels rather hacky to me.
If you don't want to add another property for this we could still check the paths for "disabled" in ArgumentModCandidateFinder

@sfPlayer1
Copy link
Contributor

sfPlayer1 commented Oct 30, 2024

Maybe I just just add a path filter regex or so -_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search for mods recursively
3 participants