Fix AWs not being applied when remapping in dev #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
reviewed
Jul 9, 2024
src/main/java/net/fabricmc/loader/impl/discovery/RuntimeModRemapper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/fabricmc/loader/impl/discovery/RuntimeModRemapper.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/net/fabricmc/loader/impl/discovery/RuntimeModRemapper.java
modmuss50
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access wideners were not being applied during remapping. This caused crashes with some mods (notably Biome O' Plenty) where an overriding method wouldn't get remapped because the
extendablewasn't seen by the remapper. The code in this PR is inspired by code in Loom that does the same thing.