Prioritize mods with higher provided versions if their main id differs #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfPlayer1
force-pushed
the
providesPrio
branch
from
3b24f5d
to
0917a45
Compare
LlamaLad7
approved these changes
Nov 23, 2023
sfPlayer1
force-pushed
the
providesPrio
branch
from
1c31749
to
51fab36
Compare
LlamaLad7
approved these changes
Nov 26, 2023
| return found ? 0 : -1; // only a has minParent if !found, so only a has the highest prio parent | ||
| } | ||
|
|
||
| private static int compareOverlappingIds(ModCandidate a, ModCandidate b, int noMatchResult) { |
There was a problem hiding this comment.
Returning a @Nullable Integer might be better here.
modmuss50
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case outlined in #780 where interactions between provided and regular mod ids lead to undesirable results.
Whenever there is an overlap between the id+provides sets of two mods, the sets will be compared as a whole. Each matching id pair is compared, the mod with the most higher versions gets overall higher priority. The solver may of course still select the lesser result if other constraints force it to.