Depth cameras #181
Depth cameras #181
Conversation
SijmenHuizenga
force-pushed
the
depth-cameras
branch
from
d697da6 to
6a0909b
Compare
|
force pushed to rebase on master |
SijmenHuizenga
requested review from
davidoort,
mvanlobensels,
lussekatter,
Riliano and
skimslozo
There was a problem hiding this comment.
I think it looks pretty good considering our time constraints, good job! 👍
Ideas for further development: Maybe it would not be so computationally challenging to simulate the infrared "projected points" and then interpolate between them to get that accuracy gradient with higher precision close by and worse far away. The Intel Realsense camera has an algorithm that it can execute on-board in real time, basic info here:
https://www.intelrealsense.com/stereo-depth-vision-basics/
We will be happy to return to this topic after comp, right now this is okay for us to "play with"
| { | ||
| assert(multiple); | ||
| return ((numToRound + multiple - 1) / multiple) * multiple; | ||
| } |
There was a problem hiding this comment.
I am slightly confused about the rounding - how exactly does it work? Can you provide an example?
There was a problem hiding this comment.
copied it from here ;) https://stackoverflow.com/a/9194117/2328729
There was a problem hiding this comment.
it rounds up to the nearest multiple of another number
|
@Plavit Your ideas for further development sounds good! Would you like to create a new issues for this so that it doesn't get lost in pr history? :D |
Hmm, good point - may I suggest just sticking to using the depth camera issue we were using up till now? It is already classified as enhancement if I recall correctly... |
|
Let's start with a clean slate in a new ticket and keep the #153 closed. I will mark it as enhancement again :) |
|
@SijmenHuizenga Done: #187 |
This pr adds depth camera's. Read the docs on a description of how they work.