Servo controller #85
Open
Servo controller #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 17, 2017 08:49
MiloDavis
suggested changes
Feb 21, 2017
| @@ -94,4 +94,12 @@ public static ControllerEvent setOutputVoltage(double min, double max) { | |||
| public static ControllerEvent resetPosition(double position) { | |||
| return new ResetPositionEvent(position); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Make a new class called ServoInstr
| @@ -0,0 +1,26 @@ | |||
| package com.nutrons.framework.controllers; | |||
| @@ -0,0 +1,10 @@ | |||
| package com.nutrons.framework.controllers; | |||
|
|
|||
| public interface ServoEvent { | |||
There was a problem hiding this comment.
Change name to ServoInstr
| private final double angle; | ||
|
|
||
| /** | ||
| * An event which sets the servo to turn to a certain angle. |
There was a problem hiding this comment.
Is this true for all servos, or just the ones we currently have?
| @Override | ||
| public void actOn(RevServo servo) { | ||
| if (Math.abs(value) > 1.0) { | ||
| throw new EventUnimplementedException( |
There was a problem hiding this comment.
Throw IllegalArgumentException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Merging