Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vvmax #54

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Vvmax #54

merged 6 commits into from
Oct 1, 2024

Conversation

cwjames1983
Copy link
Collaborator

This is for Wayne's V/Vmax paper: see papers/Vvmax

It uses FRB redshifts from the ICS paper.

I've pulled in main - there were, amazingly, no conflicts to resolve!

"zdm" is only used for calculating, well, z(DM), and also luminosity distances, but it was a very convenient library for doing so.

Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider how much of the code could be exposed in the main folder of the
repo, e.g .in zdm/vvmax

otherwise, looks great!

papers/Vvmax/Data/all_unloc_frb_data.dat Show resolved Hide resolved
papers/Vvmax/RLFs.py Show resolved Hide resolved
papers/Vvmax/RLFs.py Outdated Show resolved Hide resolved
papers/Vvmax/RLFs.py Show resolved Hide resolved
papers/Vvmax/calc_vvmax.py Outdated Show resolved Hide resolved
papers/Vvmax/calc_vvmax.py Show resolved Hide resolved
papers/Vvmax/calc_vvmax.py Outdated Show resolved Hide resolved
papers/Vvmax/calc_vvmax.py Show resolved Hide resolved
papers/Vvmax/calc_vvmax.py Show resolved Hide resolved
papers/Vvmax/make_paper_cdf_plot.py Show resolved Hide resolved
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellente

@cwjames1983 cwjames1983 merged commit c144f0e into main Oct 1, 2024
6 checks passed
@cwjames1983 cwjames1983 deleted the vvmax branch October 1, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants