DECaLS dr8->dr10 #181
Merged
DECaLS dr8->dr10 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profxj
approved these changes
May 9, 2024
There was a problem hiding this comment.
thx for this.
and, yes, we'll need to update chime_ffff_pz
maybe you can do so directly @SunilSimha ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating from DR8 to DR10 for our DECaLS data. Might potentially break the CHIME_FFFF_PZ PATH code and hence, I'm requesting that @bandersen441 and @lordrick94 take a look.
Most important change is the way stars are defined. Instead of using the
gaia_pointsourceflag which is no longer available in thetractortable, I am using the morphologicaltypeclassification. Stars are nowtype=='PSF'in this new system.