Merge branch 'main' into deccal_fussin

FRBs · Oct 25, 2023 · 2cb6674 · 2cb6674
2 parents d062015 + 71cb80c
commit 2cb6674
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 23 deletions.
diff --git a/frb/data/FRBs/FRB20191001A.json b/frb/data/FRBs/FRB20191001A.json
@@ -1,11 +1,11 @@
 {
     "DM": {
         "unit": "pc / cm3",
-        "value": 507.9
+        "value": 507.0
     },
     "DMISM": {
         "unit": "pc / cm3",
-        "value": 44.70343299174315
+        "value": 44.703306040135054
     },
     "DM_err": {
         "unit": "pc / cm3",
@@ -21,16 +21,12 @@
         "value": 0.9
     },
     "cosmo": "Planck18",
-    "dec": -54.74773889,
+    "dec": -54.74821877,
     "eellipse": {
-        "a": 0.13,
-        "a_sys": 0.1737,
-        "b": 0.08,
-        "b_sys": 0.16,
+        "a": 0.274,
+        "b": 0.188,
         "cl": 68.0,
-        "cl_sys": 68.0,
-        "theta": 90.0,
-        "theta_sys": 90.0
+        "theta": 79.26
     },
     "fluence": {
         "unit": "Jy ms",
@@ -67,10 +63,11 @@
             "value": 0.2
         }
     },
-    "ra": 323.3513042,
+    "ra": 323.3517842,
     "refs": [
         "Bhandari2020b",
         "Day2021",
+        "Shannon2023",
         "Bhandari+2020"
     ],
     "repeater": false,

diff --git a/frb/data/FRBs/FRBs_base.csv b/frb/data/FRBs/FRBs_base.csv
@@ -14,7 +14,7 @@ FRB20190611B,320.7455833,-79.39758333,0.34,0.32,1.12,1.07,0,332.63,0.04,10,2,20,
 FRB20190614D,65.07552,73.70674,0.8,0.4,,,67,959,1,0.62,0.07,,,,FALSE,Law2020
 FRB20190711A,329.41925,-80.358,0.12,0.075,0.646,0.563,90,587.9,1,34,3,9,2,0.52172,TRUE,"MacQuart2020,Day2020,Day2021"
 FRB20190714A,183.9797083,-13.021,0.17,0.1,0.5191,0.376,90,504.13,0.1,12,2,,,0.2365,FALSE,"Heintz2020,Day2021"
-FRB20191001A,323.3513042,-54.74773889,0.13,0.08,0.1737,0.16,90,507.9,0.07,143,15,55.5,0.9,0.234,FALSE,"Bhandari2020b,Day2021"
+FRB20191001A,323.3517842,-54.74821877,0.274,0.188,,,79.26,507,0.07,143,15,55.5,0.9,0.234,FALSE,"Bhandari2020b,Day2021,Shannon2023"
 FRB20191228A,344.4304167,-29.59408333,0.34,0.34,0.83,0.823,0,298,0.05,,,,,0.243,FALSE,"Bhandari2021,Day2021"
 FRB20200120E,149.4778333,68.81888889,0.4,0.4,,,0,87.818,0.007,,,-29.8,0.5,0.0008,TRUE,"Bhardwaj2021,Kirsten2021"
 FRB20200430A,229.7064167,12.37675,0.24,0.17,0.98,0.251,0,380,,,,,,0.161,FALSE,"Bhandari2021,Day2021"

diff --git a/frb/data/Galaxies/20191001A/FRB20191001A_host.json b/frb/data/Galaxies/20191001A/FRB20191001A_host.json
@@ -2,7 +2,7 @@
     "FRB": "FRB20191001A",
     "cosmo": "Planck18",
     "dec": -54.74848055555556,
-    "dec_FRB": -54.74773889,
+    "dec_FRB": -54.74821877,
     "derived": {
         "AV_nebular": 1.7228824476944598,
         "AV_old": 1.06,
@@ -129,12 +129,12 @@
         "[OIII] 5007_err": 3.4581101653134785e-17
     },
     "offsets": {
-        "ang_avg": 2.896294896100312,
-        "ang_avg_err": 0.20210988687941508,
-        "ang_best": 2.8874997802548483,
-        "ang_best_err": 0.20230116271822338,
-        "physical": 11.098657079336123,
-        "physical_err": 0.7775831697422234
+        "ang_avg": 0.9900155943104287,
+        "ang_avg_err": 0.20378259273734756,
+        "ang_best": 0.9479413599948026,
+        "ang_best_err": 0.20808072062543884,
+        "physical": 3.6435937269485312,
+        "physical_err": 0.7997980047773585
     },
     "photom": {
         "DECaL_g": 19.176352207518754,
@@ -227,7 +227,7 @@
         "ra_source": 0.000407
     },
     "ra": 323.3518333333333,
-    "ra_FRB": 323.3513042,
+    "ra_FRB": 323.3517842,
     "redshift": {
         "z": 0.234,
         "z_FRB": 0.234,

diff --git a/frb/figures/finder.py b/frb/figures/finder.py
@@ -85,10 +85,12 @@ def generate(image, wcs, title, flip_ra=False, flip_dec=False,
           If provided, place a mark in red at this coordinate
         secondary_coord (astropy.coordinates.SkyCoord, optional):
           If provided, place a mark in cyan at this coordinate
-          Assume it is an offset star (i.e. calculate offsets)
+          It is assumeed this is for an offset star (i.e. calculate offsets)
+          unless secondary_offset = False
         secondary_offset (bool, optional):
-          If True, secondary_coord is an offset star
-          Otherwise, it is considered part of a pair of sources
+          If True, the secondary_coord provide is for an offset star
+          Otherwise, secondary_coord is considered the second
+          of a pair of scientific sources
         third_coord (astropy.coordinates.SkyCoord, optional):
           If provided, place a mark in yellow at this coordinate
         slit (tuple, optional):