Timezone revision: separation of rules and offset #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
FObersteiner
commented
Oct 25, 2024
•
FObersteiner
commented
- revise how time zones and UTC offsets are handled, so that a pointer to a (constant) Timezone can be used to make zoned datetime
- verify that handling of Timezone is safe;
- a tz can be de-initialized without causing segfault
- a datetime with a de-initialized Timezone is still valid, i.e. UTC offset is still correct, can be converted to another tz etc. - at least if the Timezone was declared as 'const'.
FObersteiner
commented
Oct 27, 2024
tests/test_timezone.zig
Outdated
Comment on lines
61
to
76
| test "tz deinit is mem-safe" { | ||
| var tzinfo = try Tz.fromTzdata("Asia/Tokyo", testing.allocator); | ||
| const dt = try Datetime.fromFields(.{ .year = 2027, .tz_options = .{ .tz = &tzinfo } }); | ||
| tzinfo.deinit(); | ||
|
|
||
| try testing.expectEqualStrings("", dt.tzName()); | ||
| try testing.expectEqualStrings("JST", dt.tzAbbreviation()); | ||
|
|
||
| // FIXME : | ||
| // // having tz be something else does not alter the datetime: | ||
| // tzinfo = try Tz.fromTzdata("Asia/Kolkata", testing.allocator); | ||
| // defer tzinfo.deinit(); | ||
| // try testing.expectEqualStrings("JST", dt.tzAbbreviation()); | ||
| // try testing.expectEqualStrings("", dt.tzName()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Uncomment the lines; looks like we created a new footgun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.