Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This sets the types root to
dist/index.d.ts
. Previously, the types root pointed todist/app.d.ts
, which prevented GoFSH from being imported property in other applications.Testing Instructions:
Repro the problem:
npm install
npm run build
and observe compile errorsTest the solution:
npm pack
to create the module filegofsh-2.3.1.tgz
gofsh-2.3.1.tgz
to the simple TS project you downloadednpm install --save file:gofsh-2.3.1.tgz
npm run build
and observe that it builds cleanlyRelated Issue: Discovered and discussed in FSH VS Code PR #97