Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Counted mixin class and refactor form signature computation #178

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Jun 29, 2023

In Firedrake we have been running into form signature stability problems with our Constants since they are implemented differently to how they are done in UFL. Specifically we need to add them to renumbering when the form signature is calculated.

I have refactored the counted_init part of UFL and replaced it with a Counted mixin class. This means that we can compute the renumbering for all instances of Counted, rather than specifically for Coefficients, Constants etc.

@dham dham marked this pull request as ready for review July 5, 2023 15:17
@dham dham requested a review from mscroggs July 5, 2023 15:17
@connorjward
Copy link
Contributor Author

@mscroggs please could you take a look at this? Tests appear to be failing because of some unrelated linting issues. I suspect flake8 have released a new (stricter) version.

@mscroggs mscroggs merged commit b0d635a into FEniCS:main Aug 8, 2023
11 checks passed
@mscroggs mscroggs mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants