Refactoring news-routes to be simpler and not using setInterval #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #454
getNews.js
router.get(/news/${page})
-> replaced withrouter.get(/news/:slug)
app.use("/news", newsRouter)
to theexpress.js
is not cluttered with codeSince the setInterval was adding so many routes to express, this has a good chance to be memory-leaking piece of code