Get default config values from environment #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is refresh guaranteed to be called on startup? |
|
Yep, it’s called in the constructor |
Brutus5000
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Brutus5000 requested this feature to make managing secrets easier in kubernetes. This way values like the database password which are never going to change dynamically anyway can be stored in a
Secretobject and mapped to the environment while non-sensitive data can be stored in aConfigMapand mapped to a volume that will be able to trigger the dynamic changes. Since kubernetes doesn't really support merging those two things into a single file, this feature will make setting up the configuration a lot easier and more idiomatic.NOTE: This will only work for values which are expected to be strings! This should not be a problem since this feature is only intended to be used for passwords.