Refactor game options handling / Issue/#859 game title constraints #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
force-pushed
the
refactor-game-options
branch
4 times, most recently
from
80d270d
to
b4bb165
Compare
Askaholic
force-pushed
the
refactor-game-options
branch
from
b4bb165
to
7b04212
Compare
Askaholic
force-pushed
the
refactor-game-options
branch
from
7b04212
to
11ef420
Compare
Askaholic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a few ideas that were started in #900 and reworks them into a standalone PR. Map data is now fetched when the game is created and immediately whenever the map is changed. This will allow us to update the validity for unranked maps immediately instead of waiting until the game is launched to perform that check. Since the map data may be accessed more frequently now, we cache it in the game service using an LRU cache.
Closes #859