-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes integration and graceful shutdown #960
Conversation
696123a
to
89d91ef
Compare
This is great stuff, reminds me of how LiveKit works. terminationGracePeriodSeconds to 5 hours in the helm chart, ensuring Kubernetes gives sufficient time for the pod to gracefully shut down. Extremely doable :D |
51b6595
to
939ac58
Compare
except Exception as ex: # pragma: no cover | ||
except DisabledError: | ||
# TODO: Respond with correlation uid for original message | ||
await self.send({"command": "disabled", "request": cmd}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could rename the field to something else. Maybe request_command
?
939ac58
to
00ef348
Compare
Looks like the queue pop time delta becomes negative and the pop_time being in the past causes the client UI to bug out a little bit. We should probably handle that on the server and just send a
We might want the |
00ef348
to
e000ca8
Compare
e479c81
to
dc961a8
Compare
15a5c1b
to
87b9ce7
Compare
e5b0c74
to
d385ab8
Compare
d385ab8
to
ee2ca08
Compare
ee2ca08
to
56bc5a3
Compare
Adds a graceful shutdown mode where the server will stop allowing new games to be created and wait until all active games have completed before shutting down normally. The grace period time before a hard shutdown happens can be configured or short circuited by sending a second
SIGTERM
orSIGINT
to the process.Also adds a kubernetes health check server on port 2000 by default that will ensure kubernetes waits long enough for the server to start before sending over new traffic.
Closes #469