-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#607 match confirmation #608
base: v2-develop
Are you sure you want to change the base?
Feature/#607 match confirmation #608
Conversation
92adf62
to
0516987
Compare
0516987
to
52a90eb
Compare
52a90eb
to
b056152
Compare
b056152
to
3ce9d98
Compare
0fce556
to
a54330c
Compare
6df79ac
to
bee3f7f
Compare
324057c
to
7d9cf16
Compare
7d9cf16
to
ba34796
Compare
ba34796
to
20d58f6
Compare
20d58f6
to
02e1939
Compare
02e1939
to
97d09a7
Compare
new_search = Search( | ||
players=search.players, | ||
# TODO: What start time do we want to use? | ||
start_time=search.start_time, | ||
rating_type=search.rating_type, | ||
on_matched=search.on_matched | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just reuse the same object? That way we preserve the failed matching attempts / threshold expansion which would give the auto requeue a real technical benefit over just having people rejoin the queue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like yes
97d09a7
to
3ba4852
Compare
3ba4852
to
a88d3fc
Compare
This really is ready? I missed that |
Yes. Certainly ready enough to build a client implementation against. |
Adds the ability for players to accept matchmaker games before the server tries to launch them. Clients will need to respond with a
match_ready
command which has already been supported by the server with a dummy implementation for years. If some players don't accept the match within the timeout, the match will be cancelled, the players who failed to accept the match will receive a matchmaker violation and their parties will be removed from all queues. Any parties where all players accepted the match will be automatically re-entered into the queues they had been searching for before the match was found.New server messages:
match_info
: sent to create or update the match offer UI. This might also include additional information about the match in the future.Example:
match_notice
: sent to players who are searching together to notify them which other player(s) in their party did not accept the match.Example:
Required client messages:
match_ready
: response tomatch_info
with attributeready=False
to mark ones self as ready. All players in the match must respond with amatch_ready
message before the game launch sequence will begin.Example:
Requires client changes as described in FAForever/downlords-faf-client#1783.
Closes #607