fix: connection could be called twice on set #570

hannojg · 2024-07-22T06:08:15Z

Details

This PR fixes cases where a call to Onyx.set could invoke a Onyx.connect listener twice.
For withOnyx connections this isn't happening, as they are already guarded by previous equal comparisons.

The fix here is to add a map that will store all previous values that were send to the Onyx.connect callback. We can't reuse the cache here unfortunately, as it can contain values while no data has been send to the connection yet (and thus a comparison would lead to us not sending to the connection.

For useOnyx I had to add a special parameter to Onyx.connect called alwaysNotify which is false by default.
useOnyx might uses a selector to transform the data. The output of that selector can change, even though the input data stay the same.
Thus for useOnyx we always have to call the connect callback.

Related Issues

#569

Automated Tests

Added a test that explicitly tests for the edge case where a connection would be called twice
Fixed previous test that now has a reduced connection callback count which is expected

Manual Tests

n/a

Author Checklist

Screenshots/Videos

Note: pressing the send button might be buggy in the recordings, its a know issue first reported here and is not related to this PR.

Android: Native

Screen.Recording.2024-07-22.at.13.11.30.mov

Android: mWeb Chrome

Screen.Recording.2024-07-22.at.12.53.24.mov

iOS: Native

Screen.Recording.2024-07-22.at.12.46.08.mov

iOS: mWeb Safari

iOS-mWeb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2024-07-23T13:51:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

2024-07-23.17.22.36.mov

Android: mWeb Chrome

2024-07-23.16.58.23.mov

iOS: Native

2024-07-23.16.53.52.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop_3OwDY93A.mp4

mountiny

Changes look good to me too, waiting for a c+ testing

tests/unit/onyxTest.ts

Co-authored-by: Vit Horacek <[email protected]>

blazejkustra · 2024-07-23T14:31:05Z

lib/types.ts

@@ -263,6 +263,11 @@ type Collection<TKey extends CollectionKeyBase, TValue, TMap = never> = {
 /** Represents the base options used in `Onyx.connect()` method. */
 type BaseConnectOptions = {
    initWithStoredValues?: boolean;
+    /**
+     * If true, it will call the callback function even if the value might hasn't changed.


I think you left an error here, right? "Value might hasn't changed"

Hm maybe my wording wasn't precise here.
When this value is true it can happen that the Onyx.conenct callback gets called with the same value multiple times (basically bypass the improvement)

Do you have an idea how to rephrase it to make it more obvious / better understandable?

Currently discussing if this param is really needed

https://expensify.slack.com/archives/C05LX9D6E07/p1721746491534399?thread_ts=1721742421.298419&cid=C05LX9D6E07

hannojg · 2024-07-23T14:42:24Z

hm, lets wait one moment before we continue, want to ask Fabio one thing who wrote the useOnxy hook. Maybe we don't need the alwaysNotify prop (conversation here)

ZhenjaHorbach · 2024-07-23T15:42:12Z

The changes look good !
I didn't find any regressions
So we are waiting for information about alwaysNotify and tests (the slack thread)

hannojg · 2024-07-23T15:50:23Z

Yes, thanks for being patient with me!
I figured that the alwaysNotify isn't needed.

There was this test that failed with the changes I made:

The thing is that the test case was a bit broken. In the test we change the selector function reference. In a react application that will only happen when the hook gets called again aka. the component re-renders (if we follow all strict rules, which we do).
The test was working before this change only because the Onyx.connect callback was called another time (which will cause a rerender in useOnyx), which is what this PR fixes:

So the solution was to fix the test by simulating how in a regular react app the selector ref would change - with a rerender

ZhenjaHorbach · 2024-07-23T16:01:03Z

@hannojg
Thanks for the detailed explanation !
Fix for tests makes sense to me !
LGTM

marcaaron

Changes look good. No blockers from me.

lib/OnyxUtils.ts

fabioh8010 · 2024-07-24T10:17:12Z

tests/unit/useOnyxTest.ts

@@ -276,6 +276,8 @@ describe('useOnyx', () => {
            expect(result.current[1].status).toEqual('loaded');

            selector = (entry: OnyxEntry<{id: string; name: string}>) => `id - ${entry?.id}, name - ${entry?.name} - selector changed`;
+            // In a react app we expect the selector ref to change during a rerender (see selectorRef/useLiveRef)
+            rerender(undefined);

            await act(async () => Onyx.merge(ONYXKEYS.TEST_KEY, {id: 'changed_id', name: 'changed_name'}));


Suggested change

await act(async () => Onyx.merge(ONYXKEYS.TEST_KEY, {id: 'changed_id', name: 'changed_name'}));

await act(async () => waitForPromisesToResolve());

expect(result.current[0]).toEqual('id - test_id, name - test_name - selector changed');

I think we can remove the Onyx.merge since the rerender() is enough to prove the selector changed

ah good idea, let me check!

We don't even need waitForPromisesToResolve() 😊 looks good?

hannojg · 2024-07-24T10:25:44Z

@mountiny I think we are good to merge!

github-actions · 2024-07-24T19:15:46Z

🚀Published to npm in v2.0.58

fabioh8010 · 2024-08-06T08:35:07Z

@hannojg I noticed that these changes are causing some tests in E/App to fail. Is this expected?

Summary of all failing tests
 FAIL  tests/unit/LocalizeTests.ts
  ● localize › formatList › formatList([ 'rory', 'vit' ])

    expect(received).toBe(expected) // Object.is equality

    Expected: "rory y vit"
    Received: "rory and vit"

      55 |         ])('formatList(%s)', (input, {[CONST.LOCALES.DEFAULT]: expectedOutput, [CONST.LOCALES.ES]: expectedOutputES}) => {
      56 |             expect(Localize.formatList(input)).toBe(expectedOutput);
    > 57 |             return Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(Localize.formatList(input)).toBe(expectedOutputES));
         |                                                                                                                            ^
      58 |         });
      59 |     });
      60 | });

      at toBe (tests/unit/LocalizeTests.ts:57:124)

  ● localize › formatList › formatList([ 'rory', 'vit', 'jules' ])

    expect(received).toBe(expected) // Object.is equality

    Expected: "rory, vit y jules"
    Received: "rory, vit, and jules"

      55 |         ])('formatList(%s)', (input, {[CONST.LOCALES.DEFAULT]: expectedOutput, [CONST.LOCALES.ES]: expectedOutputES}) => {
      56 |             expect(Localize.formatList(input)).toBe(expectedOutput);
    > 57 |             return Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(Localize.formatList(input)).toBe(expectedOutputES));
         |                                                                                                                            ^
      58 |         });
      59 |     });
      60 | });

      at toBe (tests/unit/LocalizeTests.ts:57:124)

  ● localize › formatList › formatList([ 'rory', 'vit', 'ionatan' ])

    expect(received).toBe(expected) // Object.is equality

    Expected: "rory, vit e ionatan"
    Received: "rory, vit, and ionatan"

      55 |         ])('formatList(%s)', (input, {[CONST.LOCALES.DEFAULT]: expectedOutput, [CONST.LOCALES.ES]: expectedOutputES}) => {
      56 |             expect(Localize.formatList(input)).toBe(expectedOutput);
    > 57 |             return Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(Localize.formatList(input)).toBe(expectedOutputES));
         |                                                                                                                            ^
      58 |         });
      59 |     });
      60 | });

      at toBe (tests/unit/LocalizeTests.ts:57:124)

 FAIL  tests/unit/CurrencyUtilsTest.ts (5.087 s)
  ● CurrencyUtils › isCurrencySymbolLTR › Returns false for preferredLocale es and currencyCode USD

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      53 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, locale).then(() => {
      54 |                 const isSymbolLeft = CurrencyUtils.isCurrencySymbolLTR(currencyCode);
    > 55 |                 expect(isSymbolLeft).toBe(isLeft);
         |                                      ^
      56 |             }),
      57 |         );
      58 |     });

      at toBe (tests/unit/CurrencyUtilsTest.ts:55:38)

  ● CurrencyUtils › convertToDisplayString › Correctly displays EUR in ES locale

    expect(received).toBe(expected) // Object.is equality

    Expected: "0,25 €"
    Received: "€0.25"

      168 |             ['EUR', 250000000, '2.500.000,00\xa0€'],
      169 |         ])('Correctly displays %s in ES locale', (currency, amount, expectedResult) =>
    > 170 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(CurrencyUtils.convertToDisplayString(amount, currency)).toBe(expectedResult)),
          |                                                                                                                                                 ^
      171 |         );
      172 |     });
      173 |

      at toBe (tests/unit/CurrencyUtilsTest.ts:170:145)

  ● CurrencyUtils › convertToDisplayString › Correctly displays EUR in ES locale

    expect(received).toBe(expected) // Object.is equality

    Expected: "25,00 €"
    Received: "€25.00"

      168 |             ['EUR', 250000000, '2.500.000,00\xa0€'],
      169 |         ])('Correctly displays %s in ES locale', (currency, amount, expectedResult) =>
    > 170 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(CurrencyUtils.convertToDisplayString(amount, currency)).toBe(expectedResult)),
          |                                                                                                                                                 ^
      171 |         );
      172 |     });
      173 |

      at toBe (tests/unit/CurrencyUtilsTest.ts:170:145)

  ● CurrencyUtils › convertToDisplayString › Correctly displays EUR in ES locale

    expect(received).toBe(expected) // Object.is equality

    Expected: "2500,00 €"
    Received: "€2,500.00"

      168 |             ['EUR', 250000000, '2.500.000,00\xa0€'],
      169 |         ])('Correctly displays %s in ES locale', (currency, amount, expectedResult) =>
    > 170 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(CurrencyUtils.convertToDisplayString(amount, currency)).toBe(expectedResult)),
          |                                                                                                                                                 ^
      171 |         );
      172 |     });
      173 |

      at toBe (tests/unit/CurrencyUtilsTest.ts:170:145)

  ● CurrencyUtils › convertToDisplayString › Correctly displays EUR in ES locale

    expect(received).toBe(expected) // Object.is equality

    Expected: "2.500.000,00 €"
    Received: "€2,500,000.00"

      168 |             ['EUR', 250000000, '2.500.000,00\xa0€'],
      169 |         ])('Correctly displays %s in ES locale', (currency, amount, expectedResult) =>
    > 170 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(CurrencyUtils.convertToDisplayString(amount, currency)).toBe(expectedResult)),
          |                                                                                                                                                 ^
      171 |         );
      172 |     });
      173 |

      at toBe (tests/unit/CurrencyUtilsTest.ts:170:145)

  ● CurrencyUtils › convertToShortDisplayString › Correctly displays EUR in ES locale

    expect(received).toBe(expected) // Object.is equality

    Expected: "0 €"
    Received: "€0"

      195 |             ['EUR', 250000000, '2.500.000\xa0€'],
      196 |         ])('Correctly displays %s in ES locale', (currency, amount, expectedResult) =>
    > 197 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(CurrencyUtils.convertToShortDisplayString(amount, currency)).toBe(expectedResult)),
          |                                                                                                                                                      ^
      198 |         );
      199 |     });
      200 | });

      at toBe (tests/unit/CurrencyUtilsTest.ts:197:150)

  ● CurrencyUtils › convertToShortDisplayString › Correctly displays EUR in ES locale

    expect(received).toBe(expected) // Object.is equality

    Expected: "25 €"
    Received: "€25"

      195 |             ['EUR', 250000000, '2.500.000\xa0€'],
      196 |         ])('Correctly displays %s in ES locale', (currency, amount, expectedResult) =>
    > 197 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(CurrencyUtils.convertToShortDisplayString(amount, currency)).toBe(expectedResult)),
          |                                                                                                                                                      ^
      198 |         );
      199 |     });
      200 | });

      at toBe (tests/unit/CurrencyUtilsTest.ts:197:150)

  ● CurrencyUtils › convertToShortDisplayString › Correctly displays EUR in ES locale

    expect(received).toBe(expected) // Object.is equality

    Expected: "2500 €"
    Received: "€2,500"

      195 |             ['EUR', 250000000, '2.500.000\xa0€'],
      196 |         ])('Correctly displays %s in ES locale', (currency, amount, expectedResult) =>
    > 197 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(CurrencyUtils.convertToShortDisplayString(amount, currency)).toBe(expectedResult)),
          |                                                                                                                                                      ^
      198 |         );
      199 |     });
      200 | });

      at toBe (tests/unit/CurrencyUtilsTest.ts:197:150)

  ● CurrencyUtils › convertToShortDisplayString › Correctly displays EUR in ES locale

    expect(received).toBe(expected) // Object.is equality

    Expected: "2.500.000 €"
    Received: "€2,500,000"

      195 |             ['EUR', 250000000, '2.500.000\xa0€'],
      196 |         ])('Correctly displays %s in ES locale', (currency, amount, expectedResult) =>
    > 197 |             Onyx.set(ONYXKEYS.NVP_PREFERRED_LOCALE, CONST.LOCALES.ES).then(() => expect(CurrencyUtils.convertToShortDisplayString(amount, currency)).toBe(expectedResult)),
          |                                                                                                                                                      ^
      198 |         );
      199 |     });
      200 | });

      at toBe (tests/unit/CurrencyUtilsTest.ts:197:150)


Test Suites: 2 failed, 2 skipped, 86 passed, 88 of 90 total
Tests:       12 failed, 154 skipped, 928 passed, 1094 total
Snapshots:   1 passed, 1 total
Time:        22.677 s
Ran all test suites.

hannojg · 2024-08-06T08:39:36Z

They are failing due to another bug in Onyx for which I have a PR to fix here:

fix: Onyx.clear handle collections and regular keys with an underscore #574

hannojg added 3 commits July 22, 2024 08:07

wip: connection called twice, added failing unit test

d60d3ef

store last connection callback values & compare

b7a7f2d

added alwaysNotify prop for useOnyx use case

bd0a686

hannojg changed the title ~~wip: connection called twice, added failing unit test~~ fix: connection could be called twice on set Jul 22, 2024

hannojg marked this pull request as ready for review July 22, 2024 11:12

hannojg requested a review from a team as a code owner July 22, 2024 11:12

hannojg mentioned this pull request Jul 22, 2024

Onyx connection can be called twice for the same data #569

Closed

melvin-bot bot requested review from marcaaron and removed request for a team July 22, 2024 11:13

marcaaron requested a review from mountiny July 22, 2024 18:26

mountiny assigned hannojg Jul 23, 2024

mountiny requested a review from ZhenjaHorbach July 23, 2024 13:49

fabioh8010 approved these changes Jul 23, 2024

View reviewed changes

mountiny previously approved these changes Jul 23, 2024

View reviewed changes

tests/unit/onyxTest.ts Show resolved Hide resolved

Update tests/unit/onyxTest.ts

d7a6ca0

Co-authored-by: Vit Horacek <[email protected]>

hannojg dismissed mountiny’s stale review via d7a6ca0 July 23, 2024 14:11

blazejkustra approved these changes Jul 23, 2024

View reviewed changes

hannojg added 2 commits July 23, 2024 17:45

remove alwaysNotify flag, fix test

ad77f7c

removed onyx clear test (meant for a different PR)

bc8face

ZhenjaHorbach approved these changes Jul 23, 2024

View reviewed changes

hannojg requested a review from fabioh8010 July 23, 2024 18:48

marcaaron previously approved these changes Jul 23, 2024

View reviewed changes

lib/OnyxUtils.ts Outdated Show resolved Hide resolved

lib/OnyxUtils.ts Show resolved Hide resolved

reuse valueToPass

5e571f5

hannojg dismissed marcaaron’s stale review via 5e571f5 July 24, 2024 07:24

better explained

3161a0f

fabioh8010 reviewed Jul 24, 2024

View reviewed changes

skip merge, just confirm selector changes

69d6152

hannojg requested a review from fabioh8010 July 24, 2024 10:22

fabioh8010 approved these changes Jul 24, 2024

View reviewed changes

marcaaron self-requested a review July 24, 2024 19:14

marcaaron approved these changes Jul 24, 2024

View reviewed changes

marcaaron merged commit 50d07eb into Expensify:main Jul 24, 2024
5 checks passed

This was referenced Jul 30, 2024

fix: Onyx.clear handle collections and regular keys with an underscore #574

Closed

fix: free memory from internal cache when disconnecting #575

Merged

hannojg mentioned this pull request Aug 7, 2024

fix: Onyx.clear handle collections and regular keys with an underscore (attempt Nr.2) #578

Merged

42 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: connection could be called twice on set #570

fix: connection could be called twice on set #570

hannojg commented Jul 22, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 23, 2024 •

edited

Loading

mountiny left a comment

blazejkustra Jul 23, 2024

hannojg Jul 23, 2024

hannojg Jul 23, 2024

hannojg commented Jul 23, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 23, 2024 •

edited

Loading

hannojg commented Jul 23, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 23, 2024

marcaaron left a comment

fabioh8010 Jul 24, 2024

hannojg Jul 24, 2024

hannojg Jul 24, 2024

hannojg commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

fabioh8010 commented Aug 6, 2024

hannojg commented Aug 6, 2024

-            await act(async () => Onyx.merge(ONYXKEYS.TEST_KEY, {id: 'changed_id', name: 'changed_name'}));
+            await act(async () => waitForPromisesToResolve());
+            expect(result.current[0]).toEqual('id - test_id, name - test_name - selector changed');

fix: connection could be called twice on set #570

fix: connection could be called twice on set #570

Conversation

hannojg commented Jul 22, 2024 • edited Loading

Details

Related Issues

Automated Tests

Manual Tests

Author Checklist

Screenshots/Videos

ZhenjaHorbach commented Jul 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

blazejkustra Jul 23, 2024

Choose a reason for hiding this comment

hannojg Jul 23, 2024

Choose a reason for hiding this comment

hannojg Jul 23, 2024

Choose a reason for hiding this comment

hannojg commented Jul 23, 2024 • edited Loading

ZhenjaHorbach commented Jul 23, 2024 • edited Loading

hannojg commented Jul 23, 2024 • edited Loading

ZhenjaHorbach commented Jul 23, 2024

marcaaron left a comment

Choose a reason for hiding this comment

fabioh8010 Jul 24, 2024

Choose a reason for hiding this comment

hannojg Jul 24, 2024

Choose a reason for hiding this comment

hannojg Jul 24, 2024

Choose a reason for hiding this comment

hannojg commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

fabioh8010 commented Aug 6, 2024

hannojg commented Aug 6, 2024

hannojg commented Jul 22, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 23, 2024 •

edited

Loading

hannojg commented Jul 23, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 23, 2024 •

edited

Loading

hannojg commented Jul 23, 2024 •

edited

Loading