Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent italic or strikethrough emojis on Android #534

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Nov 5, 2024

Details

This PR fixes adding italics and strikethrough style to the emojis on Android and web platforms

Related Issues

Expensify/App#14676

Manual Tests

  1. To the text that contains emojis, add italics styling, e.g. _🥰 test 😇 test 🥹_
  2. Verify if the text has italics style and emojis don't
  3. Verify if it still works when adding other styles around it, e.g. # *~_🥰 test 😇 test 🥹_~*
  4. Verify if emojis aren't strikethrough
  5. Test it with different style combinations

Linked PRs

@Skalakid Skalakid marked this pull request as draft November 5, 2024 16:01
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions in the comments, also a unit test suite would be much appreciated.

@tomekzaw tomekzaw changed the title Fix emoji formatting Prevent italic or strikethrough emojis on Android Nov 11, 2024
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please provide some unit tests in Java to verify the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants