Add unit test for video parse

[nkdengineer]

Details

Related Issues

follow up PR: #440

Manual Tests

Linked PRs

[ZhenjaHorbach]

@nkdengineer
As far as I can see, the tests are broken
Can you check, please ?

[nkdengineer]

I'll update today

[nkdengineer]

Still investigating to find the reason the test failed.

[tomekzaw]

@nkdengineer The test with ![```test```](https://example.com/video.mp4) is failing because video alt text is escaped. Please come up with the fix for this input.

[nkdengineer]

@tomekzaw Actually the video tag has the format <video>{videoName}</video> and then the other markdowns are applied in videoName. We need some changes in expensify-common to prevent other markdowns from being applied inside the video tag.

[nkdengineer]

@tomekzaw I just added a patch about the required change in expensify-common let me know your thought.

[tomekzaw]

@nkdengineer Please re-build parser as the CI is failing.

[nkdengineer]

@tomekzaw Maybe I built the parser with the expensify-common applied patch and then the lint check failed. Do you think we need a PR in expensify-common?

[tomekzaw]

Yes, please propagate all necessary changes to expensify-common.

Also, can you please run cd parser && yarn build and commit react-native-live-markdown-parser.js again?

[nkdengineer]

Yes, please propagate all necessary changes to expensify-common.

My newest commit already runs build and đupate react-native-live-markdown-parser.js. The test fails maybe as I mentioned above. I think we can hold until I create a PR in expensify-common and it's merged.

Also, can you please run cd parser && yarn build and commit react-native-live-markdown-parser.js again?

[tomekzaw]

The test fails because react-native-live-markdown-parser.js generated on CI is different than the one that is committed.

Looks like you've added a patch in parser/ directory – but the patch file is not listed in package.json.

Also, we don't run yarn patch-package when installing dependencies on the CI.

That's why the CI is failing.

I think we can hold this PR until the PR to expensify-common is merged.

[nkdengineer]

@tomekzaw @ZhenjaHorbach An expensify-common PR here.

Expensify/expensify-common#769

[nkdengineer]

@tomekzaw The epxensify-common PR is merged and I bumped the version.

[ZhenjaHorbach]

@nkdengineer
Oh, nice job !
@tomekzaw
Looks like we are ready to move on !

[tomekzaw]

@nkdengineer Thanks for the PR!