Upgrade 2 bottleneck logs to warns #1775
Conversation
| @@ -60,7 +60,7 @@ size_t SQLitePool::getIndex(bool createHandle) { | |||
| return index; | |||
| } else { | |||
| // Wait for a handle. | |||
| SINFO("Waiting for DB handle"); | |||
| SWARN("Waiting for DB handle"); | |||
There was a problem hiding this comment.
Won't this one specifically be written in a loop while the server is receiving requests? not sure if that's a problem though, just noting.
There was a problem hiding this comment.
It's just as much of a problem when it's an info 😄
There was a problem hiding this comment.
I know; I meant, do we want to continue logging them all the time?
And what will happen if instead of thousands of lines with info we do thousands with warn?
There was a problem hiding this comment.
And what will happen if instead of thousands of lines with info we do thousands with warn?
I think we get a bugbot issue created but that's about it.
| @@ -60,7 +60,7 @@ size_t SQLitePool::getIndex(bool createHandle) { | |||
| return index; | |||
| } else { | |||
| // Wait for a handle. | |||
| SINFO("Waiting for DB handle"); | |||
| SWARN("Waiting for DB handle"); | |||
There was a problem hiding this comment.
And what will happen if instead of thousands of lines with info we do thousands with warn?
I think we get a bugbot issue created but that's about it.
These logs should not occur in normal operation (they have not happened in the last five days outside of a wonky deploy on June 7th). I'd like to upgrade them to warns so that they are very obvious when they happen.