Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expensify_prod branch #1741

Merged
merged 2 commits into from
May 21, 2024
Merged

Update expensify_prod branch #1741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f955c
Only create a stack trace for STHROW on debug
neil-marcellini May 21, 2024
c07b587
Merge pull request #1740 from Expensify/neil-STHROW-log-debug-only
flodnv May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libstuff/libstuff.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,12 @@ typedef map<string, SString, STableComp> STable;

// An SException is an exception class that can represent an HTTP-like response, with a method line, headers, and a
// body. The STHROW and STHROW_STACK macros will create an SException that logs it's file, line of creation, and
// a stack trace at the same time. They can take, 1, 2, or all 3 of the components of an HTTP response as arguments.
// (for DEBUG) a stack trace at the same time. They can take, 1, 2, or all 3 of the components of an HTTP response as arguments.
#define STHROW(...) \
do { \
SLogStackTrace(LOG_DEBUG); \
if (_g_SLogMask & (1 << LOG_DEBUG)) { \
SLogStackTrace(LOG_DEBUG); \
} \
throw SException(__FILE__, __LINE__, false, __VA_ARGS__); \
} while (false)

Expand Down