Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expensify_prod branch #1617

Merged
merged 12 commits into from
Nov 14, 2023
Merged

Update expensify_prod branch #1617

merged 12 commits into from
Nov 14, 2023

Conversation

rafecolton
Copy link
Member

Will self-merge, this code has already been peer reviewed.

Copy link

melvin-bot bot commented Nov 14, 2023

I see this code uses list. If your primary use case is just checking to see if an item exists in the list, perhaps set is a better choice, as it's much faster for random access. C++ has a variety of data structures available to choose from, so pick the best for your use case.

@rafecolton rafecolton merged commit d14c2e8 into expensify_prod Nov 14, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants