Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update StagingDeployCash for manual cherry-picks #5473

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

roryabraham
Copy link
Contributor

Fixed Issues

$ #4379

Tests

  1. Merge this PR when the StagingDeployCash is locked.
  2. Manually CP this PR.
  3. Verify that the resulting cherryPick.yml workflow run successfully updates the StagingDeployCash.

QA Steps

None.

@roryabraham roryabraham self-assigned this Sep 23, 2021
@roryabraham roryabraham requested a review from a team as a code owner September 23, 2021 22:36
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team September 23, 2021 22:36
Copy link
Contributor

@HorusGoul HorusGoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, I'm unsure if I should merge this at the moment because of the tests.

@roryabraham
Copy link
Contributor Author

Thanks @HorusGoul I can test this out.

@roryabraham roryabraham merged commit b4c69f2 into main Sep 27, 2021
@roryabraham roryabraham deleted the Rory-UpdateDeployChecklistWithManualCP branch September 27, 2021 16:46
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

CP'ing this here to test.

github-actions bot pushed a commit that referenced this pull request Sep 27, 2021
@roryabraham
Copy link
Contributor Author

Unfortunately this did not work – it seems the tag wasn't created correctly. I still need to figure out when/where to create the tag so this works as expected, but in the meantime I think we should revert this.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.2-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.2-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants