-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StagingDeployCash for manual cherry-picks #4798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Adding @tgolen as a final reviewer as he's more familiar with the process.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Manually CPing this to test if it works! |
JK, it's already been added to the checklist. So I'll have to remember to test this with another PR. |
This did not work as expected. I forgot that the |
This failure was fortuitous, as it maybe led me to a revelation of how to fix a related bug that has been marring me for months now. In case you're curious.... But that means that the fix for this is maybe actually a bit greater in scope than a quick follow-up, so we should revert this. It's not actually breaking anything, just causing red herring CP workflow failures. |
Revert PR is ready: #4815 |
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
Details
If the
cherryPick.yml
workflow was run manually (i.e: by a user other thanOSBotify
), then we need to update the deploy checklist to include the newly deployed PR.Fixed Issues
$ #4379
Tests
QA Steps
None.