Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Simplify capturing performance metrics on release builds #4640

Merged
merged 11 commits into from
Aug 13, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Aug 13, 2021

Details

It is very difficult to capture reliable performance metrics locally for things like app launch and time to interactive. There are manual ways to check this stuff, but it's very tedious to do e.g. my process has been:

  • Hardcode metrics
  • Add logs to production server
  • Build a release
  • Look at the logs and filter

👎

Fixed Issues (Related To)

Fixes https://github.com/Expensify/Expensify/issues/173770
#4027

Tests

  1. Set CAPTURE_METRICS=true flag in .env
  2. Build an Android release build
  3. Sign in
  4. Force quit the app and re-open it
  5. Verify an alert prints stats
  6. Repeat for iOS

QA Steps

None. This feature can only be enabled locally.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Android

2021-08-13_06-55-18

@marcaaron marcaaron self-assigned this Aug 13, 2021
@marcaaron marcaaron changed the title [WIP] [No QA] Simplify capturing performance metrics on release builds [No QA] Simplify capturing performance metrics on release builds Aug 13, 2021
@marcaaron marcaaron marked this pull request as ready for review August 13, 2021 17:11
@marcaaron marcaaron requested a review from a team as a code owner August 13, 2021 17:11
@MelvinBot MelvinBot requested review from timszot and removed request for a team August 13, 2021 17:11
@timszot timszot merged commit 8b10c1c into main Aug 13, 2021
@timszot timszot deleted the marcaaron-performanceStatsDump branch August 13, 2021 21:44
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @timszot in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants