fix mentions not copy to clipboard #45233

ahmedGaber93 · 2024-07-11T04:27:30Z

Details

Fixed Issues

$ #40477
$ #40403
PROPOSAL: #40477 (comment), Expensify/expensify-common#741 (comment)

Tests

Open any workspace chat
Send a message contain mention user and mention report and other text @MENTION_USER text after #MENTION_REPORT text after
Right click on the sent message then Copy to clipboard.
Paste the copied text in comopser and Verify the message pasted successfully with mentions

Verify that no errors appear in the JS console

Offline tests

Same as Tests step

QA Steps

Same as Tests step

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

I can't record the android video because android have an issue that focus out the composer and prevent me from type the message. I will check later if fixed

Android: mWeb Chrome

aw.mp4

iOS: Native

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

s.mp4

MacOS: Desktop

d.mp4

melvin-bot · 2024-07-11T04:27:35Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2024-07-11T04:33:26Z

@eh2077 I can't record the android video because android have an issue that focus out the composer and prevent me from type the message. I will check later if fixed

Android: Native

20240711071023775.mp4

eh2077 · 2024-07-11T13:48:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

0-web.mp4

MacOS: Desktop

0-desktop.mp4

eh2077 · 2024-07-11T14:17:59Z

src/libs/Clipboard/index.ts

-                'text/html': new Blob([html], {type: 'text/html'}),
-                'text/plain': new Blob([text], {type: 'text/plain'}),
+                'text/html': new Blob([htmlNonClosingTags], {type: 'text/html'}),
+                'text/plain': new Blob([htmlNonClosingTags], {type: 'text/plain'}),


Why do we also need to change text/plain here?

Good catch. I change it by false.

# Conflicts: # package-lock.json # package.json

OSBotify · 2024-07-12T07:45:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:07:32Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:16:16Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:24:37Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:53:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix mentions not copy to clipboard

aabcf75

ahmedGaber93 requested a review from a team as a code owner July 11, 2024 04:27

melvin-bot bot requested review from eh2077 and removed request for a team July 11, 2024 04:27

prettier

5071036

eh2077 reviewed Jul 11, 2024

View reviewed changes

ahmedGaber93 added 2 commits July 11, 2024 18:17

fix clipboard setHtml text

6df586a

Merge branch 'main' into issue-40477

6c922b8

# Conflicts: # package-lock.json # package.json

ahmedGaber93 requested a review from eh2077 July 11, 2024 15:45

eh2077 approved these changes Jul 11, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote July 11, 2024 23:43

lakchote approved these changes Jul 12, 2024

View reviewed changes

lakchote merged commit b5f8bd3 into Expensify:main Jul 12, 2024
17 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix mentions not copy to clipboard #45233

fix mentions not copy to clipboard #45233

ahmedGaber93 commented Jul 11, 2024 •

edited

Loading

melvin-bot bot commented Jul 11, 2024

ahmedGaber93 commented Jul 11, 2024

eh2077 commented Jul 11, 2024 •

edited

Loading

eh2077 Jul 11, 2024

ahmedGaber93 Jul 11, 2024

OSBotify commented Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

fix mentions not copy to clipboard #45233

fix mentions not copy to clipboard #45233

Conversation

ahmedGaber93 commented Jul 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 11, 2024

ahmedGaber93 commented Jul 11, 2024

eh2077 commented Jul 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eh2077 Jul 11, 2024

Choose a reason for hiding this comment

ahmedGaber93 Jul 11, 2024

Choose a reason for hiding this comment

OSBotify commented Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

ahmedGaber93 commented Jul 11, 2024 •

edited

Loading

eh2077 commented Jul 11, 2024 •

edited

Loading