-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Firebase performance tracing. Improve Android boot time. #4247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this is HUGE! Great work @marcaaron!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.80-3🚀
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
Details
This PR achieves a few things all related to improving or monitoring cold boot times (which need improvement on Android specifically):
sidebar_loaded
so that we can check when the sidebar loads (this should be when it is actually on the screen and not when the list component lays out)Fixed Issues
$ #4027
Tests
As far as benchmarks go I timed how long it takes the sidebar to appear on screen before and after the changes
sidebar_load
Before Changes (ms)sidebar_load
After Changes (ms)QA Steps
No QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android