Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation into Russian #218

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

Ser-Bul
Copy link

@Ser-Bul Ser-Bul commented May 24, 2024

Hi guys, please review and let me know if you find any problems with the suggested addition.

@Jean-BaptisteC
Copy link
Contributor

Thanks for your contribution, automatic selector language is very useful
Can you fix errors?

@Ser-Bul
Copy link
Author

Ser-Bul commented May 25, 2024

Thanks for your contribution, automatic selector language is very useful Can you fix errors?

Fixed.

@Jean-BaptisteC
Copy link
Contributor

How it's works if pages is missing in russian or french.
Selector shown english page?

@Ser-Bul
Copy link
Author

Ser-Bul commented May 26, 2024

checking...

@Ser-Bul
Copy link
Author

Ser-Bul commented May 26, 2024

It just returns standard error 404.
Though it behaves so even without the 'alias.html', so it seems like something should be reconfigured in Hugo to make it fallback to English pages. But I couldn't figure out what exactly.

@pnu-s
Copy link
Member

pnu-s commented May 27, 2024

Hello there!

We'll need to discuss internally whether we want/need to translate the website into more languages than French and English. We are adding this to our next agenda and we'll let you know!

@Jean-BaptisteC
Copy link
Contributor

Is it possible to separate changes about the detection of user language in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants