Fix bug 159, add glob support to headers_remove #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the whole list is expanded before the list is split, it enables inclusion of expandos that themselves are lists. The original behaviour would result in such expandos to be treated as one header instead of the list it should have been.
The ability to use * as a suffix in removal of headers fixes https://bugs.exim.org/show_bug.cgi?id=159 If one of the headers to remove ends in *, the header checked is removed if it matches the prefix (header without the *)
|
Also added to https://bugs.exim.org/show_bug.cgi?id=159#c6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the code to allow for both * as a glob in headers_remove and change the splitting of the list to after expansion has been done to allow for inclusion of expandos that results in lists themselves.