[tests] Fix Backend.ETS tests #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point along the way these tests broke. It seems that the pruning timer is only set up once (when the first instance of Backend.ETS is spawned), and so in the "timeout pruning" test the prune timer never fires, so the bucket never gets pruned. This indicates an issue with the backend architecture, and with the structure of the tests, but for now we can fix this by deleting the ETS table between test runs, so the timer will be initialized on each run. This commit also includes some other minor tweaks: - Change the key used in the pruning test - Use start_supervised in test setup - Remove the :ets_table_name option to Backend.ETS, which was never actually used
epinault
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
At some point along the way these tests broke. It seems that the pruning timer is only set up once (when the first instance of Backend.ETS is spawned), and so in the "timeout pruning" test the prune timer never fires, so the bucket never gets pruned.
This indicates an issue with the backend architecture, and with the structure of the tests, but for now we can fix this by deleting the ETS table between test runs, so the timer will be initialized on each run.
This commit also includes some other minor tweaks: